Change seed from int64 to uint64 #2438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenButtolph
commented
Dec 6, 2023
Comment on lines
+40
to
+42
| func (r *rng) Seed(seed uint64) { | ||
| r.lock.Lock() | ||
| r.rng.Seed(uint64(seed)) | ||
| r.rng.Seed(seed) |
There was a problem hiding this comment.
We really shouldn't have been casting this before... There wasn't a good reason to take in an int64.
| @@ -113,7 +113,7 @@ func (w *windower) Proposers(ctx context.Context, chainHeight, pChainHeight uint | |||
| } | |||
|
|
|||
| seed := chainHeight ^ w.chainSource | |||
| w.sampler.Seed(int64(seed)) | |||
joshua-kim
approved these changes
Dec 6, 2023
patrick-ogrady
approved these changes
Dec 6, 2023
|
(bits used here shouldn't change, so should be a no-op during verification) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Previously we used
int64for theseedto stay in-line with the standard library... However, internally casting fromint64touint64is weird. Additionally, we currently do a number of bitwise operations (uint64) to generate the seed in the proposervm.How this works
Reduces the number of casts we need to do.
How this was tested
CI