Drop explicit calls to chain.GetTx from txs execution paths #2431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abi87
commented
Dec 6, 2023
abi87
commented
Dec 6, 2023
| @@ -96,6 +96,7 @@ func TestApricotProposalBlockTimeVerification(t *testing.T) { | |||
| StartTime: utx.StartTime(), | |||
| NextTime: chainTime, | |||
| EndTime: chainTime, | |||
| Priority: utx.CurrentPriority(), | |||
There was a problem hiding this comment.
needed for rewritten RewardStaker to pass
abi87
commented
Dec 6, 2023
Comment on lines
-93
to
-81
| type stakerAttributes struct { | ||
| shares uint32 | ||
| rewardsOwner fx.Owner | ||
| validationRewardsOwner fx.Owner | ||
| delegationRewardsOwner fx.Owner | ||
| proofOfPossession *signer.ProofOfPossession |
There was a problem hiding this comment.
this PR promotes this struct to state package, renaming it StakerRewardAttributes
abi87
commented
Dec 6, 2023
| "github.com/ava-labs/avalanchego/vms/platformvm/txs" | ||
| ) | ||
|
|
||
| func getStakerColdAttributes(chain Chain, stakerID ids.ID) (*StakerColdAttributes, error) { |
There was a problem hiding this comment.
these methods are just to avoid code duplication across state.State and state.Diff.
MerkleDB implementation is likely to have different implementation and not require these methods
abi87
changed the title
danlaine
reviewed
Dec 11, 2023
danlaine
reviewed
Dec 11, 2023
|
This PR has become stale because it has been open for 30 days with no activity. Adding the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
MerkleDB is likely to require dropping the use of
Chain.GetTxin txs execution in favour of smaller, more specific data, whose lifetime is bounded as stakers objects' one. That is to say object that can be deleted once staker is removed, unlike txs which are currently stored indefinitely on disk.This PR is a step into that direction: without removing
Chain.GetTx, we add a couple of method tostate.Chaininterface. What we achieve in this PR is thatchain.GetTxwon't be explicitly called in txs execution, outside of thestatepackage.What we gain in this way is freedom for a merkleDB based P-chain to avoid storing txs into the merkleDB section, since they won't be needed to verify transactions.
In this PR we still use
chain.GetTxunder the hood, so that we avoid storing extra data to db and requiring a db migration.The increase in LOC is mostly due to mock implementation of the new methods
How this works
This PR adds
GetChainSubnet(chainID ids.ID) (ids.ID, error)GetStakerRewardAttributes(stakerID ids.ID) (*StakerRewardAttributes, error)to
state.Chain.This PR does not:
DeleteStakerRewardAttributes(similar toDeleteStaker, to bound cold attribute lifetime), yet, since stakers cold attribute are not store independently from txs. But a P-chain merkleDB could!How this was tested
CI