Prefer gossiping bootstrapper IPs #2400
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenButtolph
commented
Nov 30, 2023
| @@ -27,7 +27,7 @@ const ( | |||
|
|
|||
| MaxContainersLen = int(4 * DefaultMaxMessageSize / 5) | |||
|
|
|||
| DefaultNetworkPeerListNumValidatorIPs = 15 | |||
There was a problem hiding this comment.
Set this so that we will (even in the first message) send some non-bootstrapper IPs so that the first round of connections don't just result in everyone sending the same peerlists (and therefore the nodes not quickly connecting to the wider network)
dhrubabasu
reviewed
Nov 30, 2023
StephenButtolph
added
the
DO NOT MERGE
Co-authored-by: Dhruba Basu <[email protected]> Signed-off-by: Stephen Buttolph <[email protected]>
| s.Initialize(uint64(len(unknownValidators))) | ||
| var bootstrapperIDs set.Set[ids.NodeID] | ||
| for _, bootstrapper := range genesis.GetBootstrappers(n.config.NetworkID) { | ||
| bootstrapperIDs.Add(bootstrapper.ID) |
There was a problem hiding this comment.
This will initialize the Set if it hasn't been yet, right?
|
This PR has become stale because it has been open for 30 days with no activity. Adding the |
|
This is no longer needed because |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
How this works
How this was tested