P-Chain merkledb -- remove caches #2392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danlaine
commented
Nov 29, 2023
| @@ -674,31 +542,23 @@ func (s *state) GetSubnets() ([]*txs.Tx, error) { | |||
|
|
|||
| func (s *state) AddSubnet(createSubnetTx *txs.Tx) { | |||
| s.addedPermissionedSubnets = append(s.addedPermissionedSubnets, createSubnetTx) | |||
| if s.permissionedSubnetCache != nil { | |||
| s.permissionedSubnetCache = append(s.permissionedSubnetCache, createSubnetTx) | |||
There was a problem hiding this comment.
s.permissionedSubnetCache has to be updated, or else GetSubnets may return a stale result after the first call.
abi87
reviewed
Dec 1, 2023
|
|
||
| // UTXOs section | ||
| modifiedUTXOs map[ids.ID]*avax.UTXO // map of UTXO ID -> *UTXO | ||
| utxoCache cache.Cacher[ids.ID, *avax.UTXO] // UTXO ID -> *UTXO. If the *UTXO is nil the UTXO doesn't exist | ||
| modifiedUTXOs map[ids.ID]*avax.UTXO // map of UTXO ID -> *UTXO | ||
|
|
||
| // Metadata section | ||
| chainTime, latestComittedChainTime time.Time |
There was a problem hiding this comment.
@danlaine do we really need latestComittedChainTime and latestCommittedLastAcceptedBlkID? I can't recall if we do
There was a problem hiding this comment.
They can save us from doing unnecessary writes but they'll probably be removed in a subsequent PR as we change how we commit this data to merkledb (i.e. with views)
abi87
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
merkledb does its own caching. Instead of caching in both
stateandmerkledb, we can just rely on merkledb to cache bytes and parse those bytes.How this works
CTRL + X
How this was tested
Existing UT