Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tmpnet fixture to include Proof-of-Possession for initial stakers #2391

Merged
merged 3 commits into from
Dec 11, 2023

Conversation

marun
Copy link
Contributor

@marun marun commented Nov 29, 2023

As per #2371

@marun marun force-pushed the tmpnet-genesis-bls branch 2 times, most recently from 2cd142f to 8eebe59 Compare November 30, 2023 20:16
@marun marun marked this pull request as ready for review November 30, 2023 20:16
@marun marun requested review from abi87 and gyuho as code owners November 30, 2023 20:16
@marun marun force-pushed the tmpnet-genesis-bls branch from 5feb272 to 9dea92e Compare November 30, 2023 21:16
@marun marun self-assigned this Dec 1, 2023
@marun marun force-pushed the tmpnet-genesis-bls branch 2 times, most recently from 64da06f to ed93dc9 Compare December 10, 2023 03:43
@StephenButtolph StephenButtolph added the testing This primarily focuses on testing label Dec 10, 2023
@StephenButtolph StephenButtolph added this to the v1.10.18 milestone Dec 10, 2023
@@ -206,6 +202,24 @@ func (nc *NodeConfig) EnsureKeys() error {
return nc.EnsureNodeID()
}

// Derives the nodes proof-of-possession. Requires the node to have a
// BLS signing key.
func (nc *NodeConfig) GetProofOfPosession() (*signer.ProofOfPossession, error) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo? ProofOfPossession?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, done.

@marun marun force-pushed the tmpnet-genesis-bls branch from ed93dc9 to 8028a36 Compare December 10, 2023 18:28
Copy link
Contributor

@abi87 abi87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@StephenButtolph StephenButtolph added this pull request to the merge queue Dec 10, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 10, 2023
@marun
Copy link
Contributor Author

marun commented Dec 10, 2023

Flaked on #1993. Retesting...

@StephenButtolph StephenButtolph added this pull request to the merge queue Dec 11, 2023
Merged via the queue into dev with commit 159aafb Dec 11, 2023
16 checks passed
@StephenButtolph StephenButtolph deleted the tmpnet-genesis-bls branch December 11, 2023 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing This primarily focuses on testing
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants