vms/platformvm: Verify txs before building a block
#2359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhrubabasu
changed the base branch from
dev
to
TestBuildBlockForceAdvanceTime
abi87
approved these changes
Dec 12, 2023
StephenButtolph
approved these changes
Dec 12, 2023
joshua-kim
added a commit
that referenced
this pull request
Dec 13, 2023
commit 82fbc97 Author: Stephen Buttolph <[email protected]> Date: Tue Dec 12 18:30:09 2023 -0500 Add ACP signaling (#2476) commit ac5a00e Author: Joshua Kim <[email protected]> Date: Tue Dec 12 17:42:32 2023 -0500 Refactor p2p unit tests (#2475) Signed-off-by: Joshua Kim <[email protected]> Co-authored-by: Dan Laine <[email protected]> commit 0b2b109 Author: Dhruba Basu <[email protected]> Date: Tue Dec 12 16:48:28 2023 -0500 `vms/platformvm`: Verify txs before building a block (#2359) Co-authored-by: Stephen Buttolph <[email protected]> commit 4be744e Author: Joshua Kim <[email protected]> Date: Tue Dec 12 15:08:48 2023 -0500 P2P AppError handling (#2248) Signed-off-by: Joshua Kim <[email protected]> Co-authored-by: Stephen Buttolph <[email protected]> commit 7963115 Author: Dhruba Basu <[email protected]> Date: Tue Dec 12 14:37:59 2023 -0500 `vms/platformvm`: Add `TestBuildBlockForceAdvanceTime` test (#2472) Co-authored-by: Stephen Buttolph <[email protected]> commit dc472ec Author: Dhruba Basu <[email protected]> Date: Tue Dec 12 14:37:43 2023 -0500 `vms/platformvm`: Permit usage of the `Transactions` field in `BanffProposalBlock` (#2451) Co-authored-by: Stephen Buttolph <[email protected]> Signed-off-by: Joshua Kim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
This PR changes the block building process to verify the txs against each other before putting them into a block. This makes it impossible to build an invalid block.
How this works
Copy over relevant block verification code to build a txDiff to verify against. Drop any transactions that fail this process.
How this was tested
CI