Drop Pending Stakers 4 - minimal UT infra cleanup #2332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abi87
commented
Nov 17, 2023
| @@ -36,7 +36,7 @@ func TestBoundedBy(t *testing.T) { | |||
| End: bEndTime, | |||
| Wght: defaultWeight, | |||
| } | |||
| require.False(BoundedBy(a.StartTime(), b.EndTime(), b.StartTime(), b.EndTime())) | |||
| require.False(BoundedBy(a.StartTime(), a.EndTime(), b.StartTime(), b.EndTime())) | |||
marun
approved these changes
Dec 15, 2023
| @@ -691,8 +697,8 @@ func TestGetCurrentValidators(t *testing.T) { | |||
| require.Len(*innerVdr.Delegators, 1) | |||
| delegator := (*innerVdr.Delegators)[0] | |||
| require.Equal(delegator.NodeID, innerVdr.NodeID) | |||
| require.Equal(uint64(delegator.StartTime), delegatorStartTime) | |||
| require.Equal(uint64(delegator.EndTime), delegatorEndTime) | |||
| require.Equal(int64(delegator.StartTime), delegatorStartTime.Unix()) | |||
There was a problem hiding this comment.
(No action required) Maybe call Unix() where these are defined rather than at each point of use?
There was a problem hiding this comment.
It's annoying but I use delegatorStartTime as time.Time too, so can't redefine it as uint64
There was a problem hiding this comment.
Are you talking about for Add? Because adding (or comparing) seconds doesn't require a time type.
…/avalanchego into post_durango_minimal_test_infra
ceyonur
reviewed
Dec 15, 2023
ceyonur
approved these changes
Dec 15, 2023
abi87
commented
Dec 15, 2023
vms/platformvm/service_test.go
Outdated
Comment on lines
412
to
417
| balance := defaultBalance | ||
| if idx == 0 { | ||
| // we use the first key to fund a subnet creation in [defaultGenesis]. | ||
| // As such we need to account for the subnet creation fee | ||
| balance = defaultBalance - service.vm.Config.GetCreateBlockchainTxFee(service.vm.clock.Time()) | ||
| } |
There was a problem hiding this comment.
This is needed because the prior fee was 0 - now this test runs with a CreateSubnetTx fee that is non-0.
StephenButtolph
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
P-chain UT are not great, especially when it comes to testing forks. There is a whole PRs thread that addresses the issue (see #2453). This PR does the bare minumim to allow testing of Drop pending in Durango fork
How this works
Mostly is editing test environments constructors to explicitly set the fork we target in the test and a sensible fork time (that respects forks ordering at the very least). Test environment are some UT helper structs that acts as a vm in packages where we cannot reference platformvm.VM (due to import cycles)
How this was tested
This is just fixing some UTs.