-
Notifications
You must be signed in to change notification settings - Fork 699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blocks backfilling option - 2 ProposerVM #2241
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abi87
changed the title
State sync - Blocks backfilling option - ProposerVM #2240
State sync - Blocks backfilling option - ProposerVM
Oct 30, 2023
abi87
changed the title
State sync - Blocks backfilling option - ProposerVM
Blocks backfilling option - 2 ProposerVM
Oct 30, 2023
Signed-off-by: Alberto Benegiamo <[email protected]>
abi87
force-pushed
the
backfill_blocks_proposerVM
branch
from
November 2, 2023 11:35
5659b92
to
2550a87
Compare
abi87
force-pushed
the
backfill_blocks_proposerVM
branch
from
November 2, 2023 15:15
5e5d81f
to
4173d31
Compare
abi87
force-pushed
the
backfill_blocks_proposerVM
branch
from
November 3, 2023 19:55
8b643e7
to
4ac552b
Compare
5 tasks
5 tasks
5 tasks
This PR has become stale because it has been open for 30 days with no activity. Adding the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Node that state synced may need to index all blocks and transactions below state summary height. This PR introduced the possibility to do so.
The PR is somewhat large in LOC,but 1100 of these LOC are UTs. ProposerVM has pretty lengthly UTs setup.
How this works
Backfilling is split in the following PRs
How this was tested
extra UTs + successful mainnet sync with #2273 code