Standardize consensus variable names in tests #2129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenButtolph
added
consensus
StephenButtolph
commented
Oct 3, 2023
| @@ -199,9 +199,9 @@ func (s *SenderTest) SendAccepted(ctx context.Context, validatorID ids.NodeID, r | |||
| // SendGet calls SendGetF if it was initialized. If it wasn't initialized and | |||
| // this function shouldn't be called and testing was initialized, then testing | |||
| // will fail. | |||
| func (s *SenderTest) SendGet(ctx context.Context, vdr ids.NodeID, requestID uint32, vtxID ids.ID) { | |||
| func (s *SenderTest) SendGet(ctx context.Context, vdr ids.NodeID, requestID uint32, containerID ids.ID) { | |||
There was a problem hiding this comment.
Things in the common package should reference containers.
| @@ -390,9 +390,9 @@ func TestBootstrapperUnknownByzantineResponse(t *testing.T) { | |||
| } | |||
|
|
|||
| requestID := new(uint32) | |||
| sender.SendGetAncestorsF = func(_ context.Context, vdr ids.NodeID, reqID uint32, vtxID ids.ID) { | |||
| sender.SendGetAncestorsF = func(_ context.Context, vdr ids.NodeID, reqID uint32, blkID ids.ID) { | |||
There was a problem hiding this comment.
Things in the snowman package should reference blocks
JacobEverly
approved these changes
Oct 3, 2023
joshua-kim
approved these changes
Oct 3, 2023
gyuho
approved these changes
Oct 3, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Factors out some rote changes from #2102 and cleans up some testing functions.
How this works
Just variable name changes.
How this was tested
CI