Remove snowball.Initialize and snowball.Factory
#2104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danlaine
added
consensus
StephenButtolph
approved these changes
Sep 27, 2023
abi87
reviewed
Sep 27, 2023
| f := &Flat{ | ||
| params: params, | ||
| } | ||
| f.nnarySnowball.Initialize(params.BetaVirtuous, params.BetaRogue, choice) |
There was a problem hiding this comment.
q: why not dropping this Initialize as well?
There was a problem hiding this comment.
this is being done in a followup
abi87
approved these changes
Sep 27, 2023
joshua-kim
reviewed
Sep 27, 2023
| @@ -16,16 +16,18 @@ var ( | |||
| _ Consensus = (*Byzantine)(nil) | |||
| ) | |||
|
|
|||
| func NewByzantine(_ Parameters, choice ids.ID) Consensus { | |||
There was a problem hiding this comment.
Can we get rid of the unused parameter here? Looks like we only had it previous for interface signature
| @@ -26,34 +28,44 @@ func (n *Network) Initialize(params Parameters, numColors int) { | |||
| } | |||
| } | |||
|
|
|||
| func (n *Network) AddNode(sb Consensus) { | |||
| func (n *Network) AddNode(newConsensusFunc newConsensusFunc) Consensus { | |||
There was a problem hiding this comment.
Is it possible for the caller to just give us an initialized Consensus instance instead of this function result?
| @@ -28,12 +28,12 @@ func TestSnowballOptimized(t *testing.T) { | |||
|
|
|||
| sampler.Seed(seed) | |||
| for i := 0; i < numNodes; i++ { | |||
| nBitwise.AddNode(&Tree{}) | |||
| nBitwise.AddNode(NewTree) | |||
There was a problem hiding this comment.
I'm wondering if it's possible for us to pass parameters into NewTree and NewFlat so we can avoid passing in this function directly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Down with
Initializemethods.How this works
Remove
snowball.Initializeandsnowball.Factory.How this was tested
Existing UT.