Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate pullQuery method #2103

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Conversation

StephenButtolph
Copy link
Contributor

Why this should be merged

pullQuery and sendQuery are extremely similar and can be easily combined.

How this works

Refactors sendQuery to be able to be used where pullQuery is currently called.

How this was tested

CI

@StephenButtolph StephenButtolph added consensus This involves consensus cleanup Code quality improvement labels Sep 27, 2023
@StephenButtolph StephenButtolph added this to the v1.10.12 milestone Sep 27, 2023
@StephenButtolph StephenButtolph self-assigned this Sep 27, 2023
@StephenButtolph StephenButtolph added this pull request to the merge queue Sep 27, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 27, 2023
@StephenButtolph StephenButtolph added this pull request to the merge queue Sep 27, 2023
Merged via the queue into dev with commit e33f595 Sep 27, 2023
15 checks passed
@StephenButtolph StephenButtolph deleted the remove-duplicate-query-code branch September 27, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code quality improvement consensus This involves consensus
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants