Update AMI runner image and instance type #1939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danlaine
approved these changes
Aug 29, 2023
StephenButtolph
changed the title
StephenButtolph
approved these changes
Sep 25, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
This will fix issues with the public ami uploader ringing json correctly as well as timeouts with the ami build.
How this works
Using ubuntu 22.04 instead of 20.04 fixed some json parsing errors with the boto3 library. Adjusting the image for build will make builds faster and not hit the 45 minute timeout.
How this was tested
A private branch was created with these adjustments and we saw successful builds from github pipeline.