Defer parser initialization to Start #1442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshua-kim
approved these changes
Apr 28, 2023
StephenButtolph
commented
Apr 28, 2023
| @@ -45,7 +44,6 @@ func (p *parser) Parse(ctx context.Context, blkBytes []byte) (queue.Job, error) | |||
| } | |||
|
|
|||
| type blockJob struct { | |||
| parser *parser | |||
There was a problem hiding this comment.
This isn't really part of this PR... but this was dead code and having it here made the test harder to make... win win removing it
hexfusion
approved these changes
Apr 28, 2023
gyuho
reviewed
Apr 28, 2023
gyuho
approved these changes
Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Resolves #1440
How this works
On the X-chain, the Snowman VM is not guaranteed to be
InitializeduntilStartis called on the bootstrapper engine. When initializing the job parser it is possible to callParseBlock, so initializing the job parser must be deferred untilStarthas been called.How this was tested
TODO