Add BLS benchmarks #1318
Merged
Add BLS benchmarks #1318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danlaine
reviewed
Apr 11, 2023
|
|
||
| keys[i] = PublicFromSecretKey(privateKey) | ||
| } | ||
|
|
There was a problem hiding this comment.
Do we want to reset the timer after the setup?
There was a problem hiding this comment.
We use b.Run - so the timer isn't used for the outer benchmark.
danlaine
reviewed
Apr 11, 2023
Co-authored-by: Dan Laine <[email protected]>
|
|
abi87
pushed a commit
that referenced
this pull request
Apr 13, 2023
Co-authored-by: Aaron Buchwald <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Better observability into the cost of BLS aggregation + verification
How this works
Adds a benchmark
How this was tested
running the bencharm