-
Notifications
You must be signed in to change notification settings - Fork 702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Encode codec version in merkledb #1313
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…valanchego-internal into merkledb-encode-codec-version
danlaine
requested review from
abi87,
StephenButtolph,
coffeeavax,
gyuho,
hexfusion and
joshua-kim
as code owners
April 10, 2023 15:27
dboehm-avalabs
approved these changes
Apr 10, 2023
darioush
approved these changes
Apr 10, 2023
abi87
approved these changes
Apr 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
hexfusion
pushed a commit
to hexfusion/avalanchego
that referenced
this pull request
Apr 11, 2023
…va-labs#1313) Co-authored-by: StephenButtolph <[email protected]>
abi87
added a commit
that referenced
this pull request
Apr 13, 2023
Co-authored-by: Alberto Benegiamo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
The codec version should be encoded in the things the codec encodes
How this works
Encode codec version as varint in things returned by exposed methods of codec
How this was tested
Existing UT