Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encode codec version in merkledb #1313

Merged
merged 7 commits into from
Apr 11, 2023
Merged

Conversation

danlaine
Copy link

Why this should be merged

The codec version should be encoded in the things the codec encodes

How this works

Encode codec version as varint in things returned by exposed methods of codec

How this was tested

Existing UT

@danlaine danlaine self-assigned this Apr 10, 2023
@danlaine danlaine changed the base branch from master to dev April 10, 2023 15:30
@patrick-ogrady patrick-ogrady added this to the v1.10.0 (Cortina) milestone Apr 11, 2023
Copy link
Contributor

@abi87 abi87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

hexfusion pushed a commit to hexfusion/avalanchego that referenced this pull request Apr 11, 2023
@danlaine danlaine merged commit d3af2b5 into dev Apr 11, 2023
@danlaine danlaine deleted the merkledb-encode-codec-version branch April 11, 2023 17:39
abi87 added a commit that referenced this pull request Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants