Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement txs.Visitor in X chain wallet #1299

Merged
merged 8 commits into from
Apr 6, 2023
Merged

Conversation

dhrubabasu
Copy link
Contributor

Why this should be merged

Resolves a TODO.

How this works

Implements txs.Visitor interface

How this was tested

CI

@dhrubabasu dhrubabasu self-assigned this Apr 5, 2023
@coffeeavax coffeeavax self-requested a review April 5, 2023 18:05
Copy link

@danlaine danlaine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 nit otherwise lgtm

wallet/chain/x/backend.go Outdated Show resolved Hide resolved
@StephenButtolph StephenButtolph added this to the v1.10.0 (Cortina) milestone Apr 5, 2023
@StephenButtolph StephenButtolph merged commit f0573ec into dev Apr 6, 2023
@StephenButtolph StephenButtolph deleted the x-chain-wallet branch April 6, 2023 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants