Parallelize gzip compression #1293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
March 2, 2023 15:34
…o-internal into add-zstd-compression
…plify-gzip-compression
…plify-gzip-compression
…plify-gzip-compression
…plify-gzip-compression
…plify-gzip-compression
danlaine
approved these changes
Apr 5, 2023
StephenButtolph
requested review from
abi87,
gyuho,
hexfusion and
joshua-kim
as code owners
darioush
approved these changes
Apr 6, 2023
| g.bytesReader.Reset(msg) | ||
| if err := g.gzipReader.Reset(g.bytesReader); err != nil { | ||
| bytesReader := bytes.NewReader(msg) | ||
| gzipReader, err := gzip.NewReader(bytesReader) |
There was a problem hiding this comment.
seems we could pool the gzipReader too.
There was a problem hiding this comment.
We benchmarked it - the overhead of the sync pool for the reader is more than the savings for the allocation.
gyuho
approved these changes
Apr 6, 2023
StephenButtolph
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
It's weird that we can't (de)compress messages concurrently.
How this works
Removes shared state.
How this was tested
CI + benchmarking