Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace flags usage with pflags #1270

Merged
merged 8 commits into from
Mar 31, 2023
Merged

Replace flags usage with pflags #1270

merged 8 commits into from
Mar 31, 2023

Conversation

danlaine
Copy link

Why this should be merged

pflags is a superset of flags.

How this works

Remove usage of flags -- pretty straightforward.

How this was tested

Existing UT.

@danlaine danlaine requested a review from ceyonur March 30, 2023 17:00
@danlaine danlaine self-assigned this Mar 30, 2023
@joshua-kim joshua-kim added the enhancement New feature or request label Mar 30, 2023
@StephenButtolph StephenButtolph added this to the v1.10.0 (Cortina) milestone Mar 31, 2023
@StephenButtolph StephenButtolph added cleanup Code quality improvement and removed enhancement New feature or request labels Mar 31, 2023
@StephenButtolph StephenButtolph merged commit 0c1dc81 into dev Mar 31, 2023
@StephenButtolph StephenButtolph deleted the pflags branch March 31, 2023 19:56
hexfusion pushed a commit to hexfusion/avalanchego that referenced this pull request Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code quality improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants