nit

Signed-off-by: Joshua Kim <[email protected]>
ava-labs · Dec 6, 2023 · c7ec126 · c7ec126
1 parent 644d585
commit c7ec126
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 6 deletions.
diff --git a/network/p2p/network.go b/network/p2p/network.go
@@ -87,8 +87,8 @@ func (n *Network) AppResponse(ctx context.Context, nodeID ids.NodeID, requestID
 	return n.router.AppResponse(ctx, nodeID, requestID, response)
 }
 
-func (n *Network) AppRequestFailed(ctx context.Context, nodeID ids.NodeID, requestID uint32) error {
-	return n.router.AppRequestFailed(ctx, nodeID, requestID)
+func (n *Network) AppRequestFailed(ctx context.Context, nodeID ids.NodeID, requestID uint32, appErr *common.AppError) error {
+	return n.router.AppRequestFailed(ctx, nodeID, requestID, appErr)
 }
 
 func (n *Network) AppGossip(ctx context.Context, nodeID ids.NodeID, msg []byte) error {
@@ -103,8 +103,8 @@ func (n *Network) CrossChainAppResponse(ctx context.Context, chainID ids.ID, req
 	return n.router.CrossChainAppResponse(ctx, chainID, requestID, response)
 }
 
-func (n *Network) CrossChainAppRequestFailed(ctx context.Context, chainID ids.ID, requestID uint32) error {
-	return n.router.CrossChainAppRequestFailed(ctx, chainID, requestID)
+func (n *Network) CrossChainAppRequestFailed(ctx context.Context, chainID ids.ID, requestID uint32, appErr *common.AppError) error {
+	return n.router.CrossChainAppRequestFailed(ctx, chainID, requestID, appErr)
 }
 
 func (n *Network) Connected(_ context.Context, nodeID ids.NodeID, _ *version.Application) error {

diff --git a/network/p2p/network_test.go b/network/p2p/network_test.go
@@ -25,6 +25,11 @@ import (
 	"github.com/ava-labs/avalanchego/version"
 )
 
+var errFoo = &common.AppError{
+	Code:    123,
+	Message: "foo",
+}
+
 func TestAppRequestResponse(t *testing.T) {
 	handlerID := uint64(0x0)
 	request := []byte("request")
@@ -95,7 +100,7 @@ func TestAppRequestResponse(t *testing.T) {
 				callback := func(_ context.Context, actualNodeID ids.NodeID, actualResponse []byte, err error) {
 					defer wg.Done()
 
-					require.ErrorIs(t, err, ErrAppRequestFailed)
+					require.ErrorIs(t, err, errFoo)
 					require.Equal(t, nodeID, actualNodeID)
 					require.Nil(t, actualResponse)
 				}
@@ -147,7 +152,7 @@ func TestAppRequestResponse(t *testing.T) {
 				callback := func(_ context.Context, actualChainID ids.ID, actualResponse []byte, err error) {
 					defer wg.Done()
 
-					require.ErrorIs(t, err, ErrAppRequestFailed)
+					require.ErrorIs(t, err, errFoo)
 					require.Equal(t, chainID, actualChainID)
 					require.Nil(t, actualResponse)
 				}

diff --git a/network/p2p/router_test.go b/network/p2p/router_test.go