Notify block builder of txs after reject (#2549)

ava-labs · Dec 27, 2023 · 332a1b3 · 332a1b3
1 parent ee10054
commit 332a1b3
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/vms/avm/block/executor/block.go b/vms/avm/block/executor/block.go
@@ -290,6 +290,10 @@ func (b *Block) Reject(context.Context) error {
 		}
 	}
 
+	// If we added transactions to the mempool, we should be willing to build a
+	// block.
+	b.manager.mempool.RequestBuildBlock()
+
 	b.rejected = true
 	return nil
 }

diff --git a/vms/avm/block/executor/block_test.go b/vms/avm/block/executor/block_test.go
@@ -857,6 +857,7 @@ func TestBlockReject(t *testing.T) {
 
 				mempool := mempool.NewMockMempool(ctrl)
 				mempool.EXPECT().Add(validTx).Return(nil) // Only add the one that passes verification
+				mempool.EXPECT().RequestBuildBlock()
 
 				preferredID := ids.GenerateTestID()
 				mockPreferredState := state.NewMockDiff(ctrl)
@@ -916,6 +917,7 @@ func TestBlockReject(t *testing.T) {
 				mempool := mempool.NewMockMempool(ctrl)
 				mempool.EXPECT().Add(tx1).Return(nil)
 				mempool.EXPECT().Add(tx2).Return(nil)
+				mempool.EXPECT().RequestBuildBlock()
 
 				preferredID := ids.GenerateTestID()
 				mockPreferredState := state.NewMockDiff(ctrl)