Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slither fixes #77

Merged
merged 6 commits into from
Apr 12, 2024
Merged

Slither fixes #77

merged 6 commits into from
Apr 12, 2024

Conversation

michaelkaplan13
Copy link
Collaborator

@michaelkaplan13 michaelkaplan13 commented Apr 12, 2024

Why this should be merged

Addresses a handful of nits including:

  • Shadowed vars in constructors
  • Better util naming
  • Leveraging a shared onlyWhenCollateralized modifier
  • Use of SafeERC20.transfer
  • Adds custom re-entrancy guards for internal send functions

How this works

The re-entrancy guards on the internal send functions allow for receiveTeleporterMessage to call _send or _sendAndCall, which is expected either in TeleporterTokenSource when handling a multi-hop message, or when handling a SendAndCall message that in turns sends another bridge request.

How this was tested

CI

How is this documented

N/A

go.mod Show resolved Hide resolved
@michaelkaplan13 michaelkaplan13 merged commit 1c0e861 into send-and-call Apr 12, 2024
11 checks passed
@michaelkaplan13 michaelkaplan13 deleted the slither-fixes branch April 12, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants