-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get balance #2435
Merged
Merged
Get balance #2435
+186
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sukantoraymond
force-pushed
the
getBalance
branch
from
December 12, 2024 17:00
9675497
to
78f4c3c
Compare
sukantoraymond
force-pushed
the
getBalance
branch
from
December 12, 2024 19:01
9676a70
to
e752b8a
Compare
arturrez
reviewed
Dec 12, 2024
arturrez
reviewed
Dec 12, 2024
arturrez
reviewed
Dec 12, 2024
arturrez
reviewed
Dec 12, 2024
arturrez
reviewed
Dec 12, 2024
felipemadero
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Preapproving
Signed-off-by: sukantoraymond <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
avalance validator getBalance gets balance of validator of L1
How this works
Lets user choose whether to get balance of bootstrap validator (read from sidecar) or validator added after convertSubnetTx (using validatorID).
Once this PR is merged ava-labs/avalanchego#3564, we can use node id to get the node's balance, without requiring validation ID.
How this was tested
./bin/avalanche validator getBalance
How is this documented
NA