Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get balance #2435

Merged
merged 14 commits into from
Dec 13, 2024
Merged

Get balance #2435

merged 14 commits into from
Dec 13, 2024

Conversation

sukantoraymond
Copy link
Collaborator

@sukantoraymond sukantoraymond commented Dec 12, 2024

Why this should be merged

avalance validator getBalance gets balance of validator of L1

How this works

Lets user choose whether to get balance of bootstrap validator (read from sidecar) or validator added after convertSubnetTx (using validatorID).

Once this PR is merged ava-labs/avalanchego#3564, we can use node id to get the node's balance, without requiring validation ID.

How this was tested

./bin/avalanche validator getBalance

How is this documented

NA

@sukantoraymond sukantoraymond requested a review from a team as a code owner December 12, 2024 15:27
Copy link
Collaborator

@felipemadero felipemadero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Preapproving

pkg/txutils/info.go Show resolved Hide resolved
@sukantoraymond sukantoraymond merged commit 94a6d76 into main Dec 13, 2024
34 of 37 checks passed
@sukantoraymond sukantoraymond deleted the getBalance branch December 13, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done ✅
Development

Successfully merging this pull request may close these issues.

3 participants