Use network name instead of cluster name on sidecar #2303
Conversation
|
Network (for sidecar.json) is now stored in the form of etna / fuji / mainnet instead of cluster name even if clustername flag is used. |
|
Could have implemented this change in network function level, but this will impact node wiz and other node functionalities (separate from acp-77), which is why this change was not considered. |
| ginkgo.It("Start Local Node on Etna & Deploy the Subnet To Public Etna using cluster flag", func() { | ||
| _, err := commands.CreateLocalEtnaDevnetNode(testLocalNodeName, 1, utils.EtnaAvalancheGoBinaryPath) | ||
| gomega.Expect(err).Should(gomega.BeNil()) | ||
| createEtnaSubnetEvmConfig() | ||
| deployEtnaSubnetClusterFlagConvertOnly(testLocalNodeName) | ||
| _, err = commands.TrackLocalEtnaSubnet(testLocalNodeName, subnetName) | ||
| gomega.Expect(err).Should(gomega.BeNil()) | ||
| err = initPoaManagerClusterFlag(subnetName, testLocalNodeName) | ||
| gomega.Expect(err).Should(gomega.BeNil()) | ||
| }) | ||
|
|
||
| ginkgo.It("Mix and match network and cluster flags test 1", func() { | ||
| _, err := commands.CreateLocalEtnaDevnetNode(testLocalNodeName, 1, utils.EtnaAvalancheGoBinaryPath) | ||
| gomega.Expect(err).Should(gomega.BeNil()) | ||
| createEtnaSubnetEvmConfig() | ||
| deployEtnaSubnetClusterFlagConvertOnly(testLocalNodeName) | ||
| _, err = commands.TrackLocalEtnaSubnet(testLocalNodeName, subnetName) | ||
| gomega.Expect(err).Should(gomega.BeNil()) | ||
| _, err = initPoaManagerEtnaFlag(subnetName) | ||
| gomega.Expect(err).Should(gomega.BeNil()) | ||
| }) | ||
| ginkgo.It("Mix and match network and cluster flags test 2", func() { | ||
| createEtnaSubnetEvmConfig() | ||
| deployEtnaSubnetEtnaFlagConvertOnly() | ||
| _, err := commands.TrackLocalEtnaSubnet(testLocalNodeName, subnetName) | ||
| gomega.Expect(err).Should(gomega.BeNil()) | ||
| err = initPoaManagerClusterFlag(subnetName, testLocalNodeName) | ||
| gomega.Expect(err).Should(gomega.BeNil()) | ||
| }) |
There was a problem hiding this comment.
These tests make sure that --cluster and --network flags are interchangeable
|
I feel like it adds a confusion if we do it, if I understand this PR correctly. |
Why this should be merged
Currently if a blockchain is created with cluster flag and user uses additional commands like addValidator
This is because we are storing where the blockchain is deployed in in cluster name instead of which network it was deployed in.
How this works
Sidecar should show network name instead of cluster name to enable interchangeability of using --cluster vs --network (e.g. --fuji / --etna-devnet). This PR enable interchangeability of --cluster and --network flags.
How this was tested
Should pass CI
How is this documented
NA