Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating a Simulation Environment (ISUZU project) #47

Open
WJaworskiRobotec opened this issue Sep 28, 2022 · 29 comments
Open

Creating a Simulation Environment (ISUZU project) #47

WJaworskiRobotec opened this issue Sep 28, 2022 · 29 comments
Assignees
Labels

Comments

@WJaworskiRobotec
Copy link

WJaworskiRobotec commented Sep 28, 2022

Description

Creating Simulation Environment of ISUZU test track

Available data for baseline (provided by LeoDrive)

  • Lanelet2 map
  • PCD

Expected Output

The map will be implemented in two different types:
(map type 1) The environments around the road are typical 3d models (buildings, terrains, ...)
(map type 2)- The environments around the road are 3d model converted from the point cloud map

For each map type, two different outputs are expected

  • Intermediate output = 3D Model (.fbx, .obj, ... )
  • Final output = Map in each E2E simulator
@WJaworskiRobotec WJaworskiRobotec changed the title Createing a Simulation Environment (ISUZU project) Creating a Simulation Environment (ISUZU project) Sep 28, 2022
@MertClk
Copy link

MertClk commented Sep 30, 2022

Point cloud map and Lanelet2 map of our test campus can be found below.

PCD: Map link
HAD: Map link

@WJaworskiRobotec WJaworskiRobotec moved this from Todo to In Progress in Simulation Working Group Sep 30, 2022
@Hyeongseok-Jeon
Copy link

MORAI are internally processing the 3D map construction.
But constructing full 3D map will take a long time.

We need to discuss on this issue.

Image

@Hyeongseok-Jeon
Copy link

Update from MORAI

  • we decided that the road mesh model shown in above will be shared with others
  • we will employ satelite image near the road but we need to internally double check if there is no copyright issue or not
  • based on the satelite image, representative building will be modeled with simplified shape

@WJaworskiRobotec
Copy link
Author

@Hyeongseok-Jeon when we can expect the model with simplified buildings ?

@Hyeongseok-Jeon
Copy link

Several issues in creating 3D env for ISUZU project

  1. width of the road is too tight
  • issue on the bidirectional road
    Image

  • issue on the intersection -> when using our internal NPC algorithm, vehicle cannot trun left within the road mesh
    Image

  1. issues on the hd map data (lanelet2) for z axis value
    Image

  2. traffic signal issue

  • based on the data, there is a traffic sign which can not be seen from the Google road view
    Image

  • based on the data, every traffic sign is places over 10m compared to the road

If the above issues don't need to be considered, we will try to show the map with satelite image on next meeting (without building models). After selecting the buildings to be modeled from the satelite image, we can announce the due date for providing the map asset with simplified buildings.

@mehmetdogru
Copy link

mehmetdogru commented Nov 4, 2022

@Hyeongseok-Jeon

Thank you so much for working on this and sorry for the late reply.

  • issue on the bidirectional road

gtu_campus_overlapping_bidirectional_road

If that is the road shown above, we had to annotate that road overlapping with each other it is simply because that road needs to be bidirectional for routing purposes yet there is not enough space for two separate (not overlapping) roads. Since there is no other way, we can leave this one as it is.

  • issue on the intersection -> when using our internal NPC algorithm, vehicle cannot trun left within the road mesh

It is not clear to me where is this intersection or where the NPC tries to turn to but we do have problems on the turns especially for the long vehicles. So we are extending the lanelet borders in autoware.universe for long vehicles to be able to complete the turns which originally too narrow for them. I am guessing your internal NPC's are not using autoware to navigate so I am afraid this is a normal behavior if the NPC is a long vehicle. We don't want to tailor lanelet2 map much for the bus giving the HAD-Map annotation shouldn't be done wrt a specific vehicle.

issues on the hd map data (lanelet2) for z axis value

May I ask if these defects are common or on just some spesicif places?

  • based on the data, there is a traffic sign which can not be seen from the Google road view

We are using a dummy traffic light (a portable one). There is not a real traffic light on the annotated spot.

@Hyeongseok-Jeon
Copy link

Hyeongseok-Jeon commented Nov 5, 2022

@mehmetdogru

If that is the road shown above, we had to annotate that road overlapping with each other it is simply because that road needs to be bidirectional for routing purposes yet there is not enough space for two separate (not overlapping) roads. Since there is no other way, we can leave this one as it is.

It is not clear to me where is this intersection or where the NPC tries to turn to but we do have problems on the turns especially for the long vehicles. So we are extending the lanelet borders in autoware.universe for long vehicles to be able to complete the turns which originally too narrow for them. I am guessing your internal NPC's are not using autoware to navigate so I am afraid this is a normal behavior if the NPC is a long vehicle. We don't want to tailor lanelet2 map much for the bus giving the HAD-Map annotation shouldn't be done wrt a specific vehicle.

we will make 3d environment as is. In terms of the intersection passing issue, we will manage our NPC algorithm internally.

May I ask if these defects are common or on just some spesicif places?

Currently, we found that this issue is only for the specific place (node id : 175). If you found another nodes with data defection, we will let you know.

We are using a dummy traffic light (a portable one). There is not a real traffic light on the annotated spot.

Can you specify the exact 3 dimensional position and shape of the traffic light? Can we use the traffic light model provided by armağan via discord as below?
image

@mehmetdogru
Copy link

mehmetdogru commented Nov 6, 2022

Currently, we found that this issue is only for the specific place (node id : 175). If you found another nodes with data defection, we will let you know.

@mozhoku Could you also look at this issue if we have it on more places?

Can you specify the exact 3 dimensional position and shape of the traffic light? Can we use the traffic light model provided by armağan via discord as below?

@Hyeongseok-Jeon
Yes you can use this model.

As far as I know the position of traffic light (position of bulbs) as it is specified in lanelet2 map with light_bulbs tag. @mozhoku can you verify this information?

<tag k='type' v='light_bulbs' />

@Hyeongseok-Jeon
Copy link

We attached satellite image on the road mesh but 3d modeling for the building is on-going and the building to be modeled by MORAI should be discussed.

Image

@WJaworskiRobotec
Copy link
Author

WJaworskiRobotec commented Nov 9, 2022

@mehmetdogru Please provide the information about the buildings. Video, estimation of height, priority of the modeling. Please provide test routes as well

@mehmetdogru
Copy link

@WJaworskiRobotec @Hyeongseok-Jeon

Tomorrow @senagolcuk and some other of my colleagues will be on the campus. They will provide you with some video recordings related to the buildings around.

@xmfcx will provide you with the list of buildings which should be modeled first and a dense pcd map to get the height of the buildings properly.

And we will share the test route asap.

@senagolcuk
Copy link

@WJaworskiRobotec @Hyeongseok-Jeon

Tomorrow @senagolcuk and some other of my colleagues will be on the campus. They will provide you with some video recordings related to the buildings around.

@xmfcx will provide you with the list of buildings which should be modeled first and a dense pcd map to get the height of the buildings properly.

And we will share the test route asap.

@WJaworskiRobotec @Hyeongseok-Jeon @mehmetdogru

I am sharing the test route below. I will share the videos of the campus as soon as possible.

route

@xmfcx
Copy link
Contributor

xmfcx commented Nov 9, 2022

Isuzu environment dense point cloud map LAS file (3.7 GB): https://drive.google.com/file/d/14Fn9gBC7UrSyr7aytPKL7NqHZeWTD3_Z/view?usp=share_link

We'll share the list of buildings and a video recording of the route too. @WJaworskiRobotec

You can view/edit it using CloudCompare.

@mozhoku
Copy link

mozhoku commented Nov 9, 2022

Currently, we found that this issue is only for the specific place (node id : 175). If you found another nodes with data defection, we will let you know.

@mozhoku Could you also look at this issue if we have it on more places?

There are no other issues as big as that one in node heights. Sorry, I must have overlooked that one. 🙏 I've updated the map and can share with @Hyeongseok-Jeon again if it's necessary. (Our project manager is on vacation so I don't know if I can share the map publicly. I can send it from Discord if needed.)

As far as I know the position of traffic light (position of bulbs) as it is specified in lanelet2 map with light_bulbs tag. @mozhoku can you verify this information?

<tag k='type' v='light_bulbs' />

Yes, you can use the light bulb positions in HDmap. It should be fine. 👍

@WJaworskiRobotec
Copy link
Author

@xmfcx @senagolcuk @mehmetdogru Thanks a lot for really quick delivery of missing pieces !

@xmfcx
Copy link
Contributor

xmfcx commented Nov 15, 2022

@WJaworskiRobotec here is a recording of the environment and the map:

Campus Recording

The video is a bit choppy due to screen recording and visualizing the cameras without optimization. But it should give an idea about how campus looks in general.

@xmfcx
Copy link
Contributor

xmfcx commented Nov 15, 2022

@WJaworskiRobotec I've also marked the prominent buildings on the map (not particularly sorted by importance)

Google Earth Link

Google Maps Link

Should look like this:

Screenshot from 2022-11-15 13-30-36

@WJaworskiRobotec
Copy link
Author

@Hyeongseok-Jeon what is the progress of this task ?

@Hyeongseok-Jeon
Copy link

@WJaworskiRobotec

Currently we calculated the height of the aforementioned buildings based on LAS file and creation process is on going

@WJaworskiRobotec
Copy link
Author

Lets test in the ss2 with LL2 and vehicle model.

@Hyeongseok-Jeon
Copy link

We finished creating 3D env for ISUZU project with simplified buildings. It will be uploaded to drive shortly.

Image
Image
Image
Image

@xmfcx
Copy link
Contributor

xmfcx commented Dec 5, 2022

@Hyeongseok-Jeon

The level of detail in the 3D map is impressive. It's clear that you put a lot of time and effort into creating it. This high-quality map will be very useful for our simulations.

I love the way you've incorporated different elements into the map, such as roads and buildings. Great job!

We will start testing the bus in this map and provide feedback.

Thank you for your hard work on this project.

@mehmetdogru
Copy link

mehmetdogru commented Dec 7, 2022

@Hyeongseok-Jeon

Are this environment and ISUZU bus ready to try on the same scene in AWSIM?

If so, could you please share it?

@mehmetdogru
Copy link

mehmetdogru commented Dec 7, 2022

Necessary components are shared via G-Drive. @mozhoku from LeoDrive will give it a try to integrate these component into AWSIM.

@mehmetdogru
Copy link

@Hyeongseok-Jeon

@djargot has reported some problems here related to the environment during he integrates it into AWSIM. Is it possible for you to check it out?

@Hyeongseok-Jeon
Copy link

@mehmetdogru @WJaworskiRobotec I uploaded new version for the ISUZU simulation env. Please check and let me know if there are issues

@mehmetdogru
Copy link

Gebze Technical University map origin conf:

lanelet2_map_projector_type: UTM   # Options: MGRS, UTM
latitude: 40.81187906        # Latitude of map_origin, using in UTM
longitude: 29.35810110          # Longitude of map_origin, using in UTM

Please replace this conf values here to be able to use the map with autoware.universe:

https://github.com/autowarefoundation/autoware.universe/blob/b844cb12e9bf7e835f7c93a5a0c2233b15543de3/map/map_loader/config/lanelet2_map_loader.param.yaml#L3-L5

@WJaworskiRobotec
Copy link
Author

WJaworskiRobotec commented Jan 18, 2023

3D Environment was succesfully tested in AWSIM.

The only problem with AWSIM is that it supports MGRS in the Environment script, while LeoDrive use UTM coordinate system.
We had to make slight modifications to LaneletMapLoader and adjust LL2 (convert it to MGRS local coordinates using VectorMapBuilder).

Issue can be closed.

@WJaworskiRobotec WJaworskiRobotec moved this from In Progress to In Review in Simulation Working Group Jan 18, 2023
@WJaworskiRobotec WJaworskiRobotec moved this from In Review to Done in Simulation Working Group Feb 15, 2023
@stale
Copy link

stale bot commented Mar 20, 2023

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the stale label Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

No branches or pull requests

7 participants