Merge DomainAllowlistUpdates into common storage proof #3327
+129
−129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teor2345
requested review from
vedhavyas,
NingLin-P,
nazar-pc and
rg3l3dr
as code owners
teor2345
added
the
breaking-runtime
teor2345
commented
Dec 22, 2024
| timestamp, | ||
| consensus_transaction_byte_fee, | ||
| }; | ||
| for domain_id in SuccessfulBundles::<T>::iter_keys() { |
There was a problem hiding this comment.
Is this the right logic, or should there be another list of domains I’m iterating through?
What happens if there aren’t any domains at all?
There was a problem hiding this comment.
I added commit 1be717e to also iterate through the runtime upgrades.
1 task
teor2345
changed the title
teor2345
force-pushed
the
fraud-proof-data-runtime
branch
from
21a678c to
1be717e
Compare
|
Turns out PR #3329 doesn't work without these changes as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merges the domain chains allow list storage proof into the common storage proof struct. (I split #3329 into a separate PR.)
It also re-arranges those structs so an old storage proofs struct is empty, and then removes that empty struct.
Part of ticket #3281.
Code contributor checklist: