Improve logging with multiple cache groups #3290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NingLin-P
approved these changes
Dec 6, 2024
|
@teor2345 Looks like the following recently added test is failing here - |
|
It hangs, and it is not recent either, I reported it on Slack on August 1st |
|
Ahh my bad. I saw teor was updating some xdm test recently so assumed its related to that. I'll take a look then 👍🏼 |
|
There are a few flaky tests related to XDM IIRC, would be really nice to find the culprit and fix them |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It'd be confusing to debug what log messages correspond to
Code contributor checklist: