remove check of existing EnableRewards value set #3244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dariolina
requested review from
vedhavyas,
nazar-pc,
rg3l3dr and
NingLin-P
as code owners
nazar-pc
reviewed
Nov 20, 2024
| @@ -1116,10 +1116,6 @@ impl<T: Config> Pallet<T> { | |||
| fn do_enable_rewards_at( | |||
| enable_rewards_at: EnableRewardsAt<BlockNumberFor<T>>, | |||
| ) -> DispatchResult { | |||
| if EnableRewards::<T>::get().is_some() { | |||
| return Err(Error::<T>::RewardsAlreadyEnabled.into()); | |||
There was a problem hiding this comment.
If you remove the case that triggers it, then also remove corresponding enum variant from Error, though I don't know if we need to maintain variant indices in SCALE encoding, maybe @vedhavyas knows
There was a problem hiding this comment.
Its fine to remove the error variant.
Shouldn't be any scale issue within the runtime.
I dont see any usages of this variant outside runtime
There was a problem hiding this comment.
IMO we can remove the whole ability to set/reset rewards and solution range adjustment shortly.
nazar-pc
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To allow changing the set solution range or manual enablement
Code contributor checklist: