Remove cache index generic #3213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shamil-gadelshin
approved these changes
Nov 6, 2024
|
It could be anything, just increases sizes of data structures and it seems like there is little to no benefit in doing so. But we can if we really need to, RAM is the biggest constraint. |
|
One of the reasons I'm doing this is to move cluster-related utilities into from binary part of the crate into the library, but generics make it hard. There will likely be follow-up PRs after this. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After thinking about it some more I no longer think there is any practical value to support more than 256 caches per controller/farmer. It is unlikely that it will be beneficial and if desired more controllers or RAID can be used to fit into this limit.
Removing this generic simplifies code quite and reduces memory usage on cluster controller a bit.
Code contributor checklist: