Fix sector plotting getting stuck #3041
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discovered in smol-rs/async-lock#91 (comment) original polling attempt order is important and might cause issues if code was later serialized with a different order, which is exactly what was happening in
process_plotting_result
on farm-specificsectors_being_modified
that was causing that farm to stop plotting and I believe even farming.The solution is to move a piece of code into concurrent section so it can make progress.
I could have removed
process_plotting_result
by wrappingmetadata_header
in aMutex
and adding even more arguments toplot_single_sector
, but that would result in out of order log messages for end users and didn't seem to be worth it.Code contributor checklist: