Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove setting receive window size for Yamux #2791

Merged
merged 1 commit into from
May 28, 2024

Conversation

nazar-pc
Copy link
Member

Suggestion from Max to address https://forum.subspace.network/t/buffer-of-stream-grows-beyond-limit/3280?u=nazar-pc

One user confirmed it resovled those errors and the API was deprecated anyway, so 🤷‍♂️

Code contributor checklist:

Copy link
Member

@shamil-gadelshin shamil-gadelshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment from Max has a reference to the important change: "With v0.13 the buffer limit is managed at the connection level, no longer at the stream level."

Yamux window has a significant impact on the performance. So, we need to keep an eye on it.

@nazar-pc nazar-pc added this pull request to the merge queue May 28, 2024
@github-merge-queue github-merge-queue bot merged commit b8bd0e0 into main May 28, 2024
21 checks passed
@nazar-pc nazar-pc deleted the remove-receive-window-size branch May 28, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants