Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow farmer to start quickly in dev environment and shut down quickly once node RPC disconnects #2535

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

nazar-pc
Copy link
Member

Setting sync to paused unconditionally may result in node being stuck waiting until DSN sync notifications before identifying it is actually synced (this happens after some relatively recent changes where sync_paused is taken into consideration during major sync check).

On farmer side when slot notification subscription ended, but no other RPC errors, farmer was just hanging until something else calls RPC and triggers exit this way, simply returning error at the end of the subscription stream fixes this.

Code contributor checklist:

Base automatically changed from farmer-refactoring to main February 19, 2024 11:32
@nazar-pc nazar-pc dismissed shamil-gadelshin’s stale review February 19, 2024 11:32

The base branch was changed.

@nazar-pc nazar-pc merged commit df8ba53 into main Feb 19, 2024
9 checks passed
@nazar-pc nazar-pc deleted the improved-dev-experience branch February 19, 2024 13:48
@nazar-pc nazar-pc mentioned this pull request Feb 19, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants