Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move executor dispatch #2346

Merged
merged 2 commits into from
Dec 18, 2023
Merged

Move executor dispatch #2346

merged 2 commits into from
Dec 18, 2023

Conversation

nazar-pc
Copy link
Member

I do find it a bit awkward that runtime now optionally depends on the client library, but otherwise if we want to reuse we have some not very nice options:

  • make malicious domain operator, Pulsar, Space Acres depend on subspace-node
  • move into subspace-service (which doesn't know about specific runtimes right now and I'd like to keep it that way)
  • create a separate crate just for this (annoying)
  • copy-paste it into other projects (I believe this is what is being done right now, which is fragile)

Just moving it into runtime it strictly 1:1 corresponds to made the most sense to me even though it is a bit awkward hierarchy-wise.

I didn't move test dispatches as I'm not sure we will not have custom ones there, but feel free to follow-up with moving those into test runtimes too.

@ParthDesai this will simplify Pulsar a tiny bit I think.

Code contributor checklist:

@nazar-pc nazar-pc enabled auto-merge December 18, 2023 14:00
@nazar-pc nazar-pc added this pull request to the merge queue Dec 18, 2023
Merged via the queue into main with commit 33ee167 Dec 18, 2023
10 checks passed
@nazar-pc nazar-pc deleted the move-executor-dispatch branch December 18, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants