Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I do find it a bit awkward that runtime now optionally depends on the client library, but otherwise if we want to reuse we have some not very nice options:
subspace-node
subspace-service
(which doesn't know about specific runtimes right now and I'd like to keep it that way)Just moving it into runtime it strictly 1:1 corresponds to made the most sense to me even though it is a bit awkward hierarchy-wise.
I didn't move test dispatches as I'm not sure we will not have custom ones there, but feel free to follow-up with moving those into test runtimes too.
@ParthDesai this will simplify Pulsar a tiny bit I think.
Code contributor checklist: