Disallow operator registration with same operator signing key #2267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vedhavyas
requested review from
nazar-pc,
rg3l3dr and
NingLin-P
as code owners
vedhavyas
force-pushed
the
signing_key_index
branch
from
4a8ca70 to
bee7ad3
Compare
nazar-pc
previously approved these changes
Nov 23, 2023
nazar-pc
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, protocol allows operator registration with same operator signing key. This PR disallow such behavior and force operator registration to use a new signing key.
Since there could be multiple operators with same signing key on Gemini-3g, the new storage tracks all the operators using same signing key through the migration. Once runtime is upgraded, protocol will not allow such, and once all the exisiting operators who use same signing key is deregistered, we will make one more migration to update the storage such that single signing key is used by single operator.
Code contributor checklist: