Archiving optimizations #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…special wrapper and a bit of `unsafe`
…hiving` even in debug builds to make erasure coding not as painfully slow
nazar-pc
force-pushed
the
archiving-optimizations
branch
from
b82b4fc to
77a8246
Compare
liuchengxu
reviewed
Jan 1, 2022
| @@ -274,13 +272,27 @@ impl FlatPieces { | |||
| pub fn into_inner(self) -> Vec<u8> { | |||
| self.0 | |||
| } | |||
|
|
|||
| /// Iterator over individual pieces as byte slices. | |||
| pub fn as_pieces(&self) -> impl ExactSizeIterator<Item = &[u8]> { | |||
There was a problem hiding this comment.
There are a bunch of pieces.as_pieces() which just sounds like pieces as pieces, perhaps better to use flat_pieces.as_pieces in these cases. Just a thought, feel free to ignore it.
There was a problem hiding this comment.
There are a few places where it can be done, but I don't think it can be done everywhere while making perfect sense. Let's keep this in mind and maybe refactor in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The amount of memory copying and allocations in archiving bothered me for a while and I decided to finally optimize it.
The result is ~3% improvement on added benchmark. I didn't know what to expect, but I'm happy that there is an improvement.
I also enabled optimizations for some crates so I don't have to compile everything in debug mode for erasure coding to not take forever.