Added windows-2022 to matrix os options #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you also add it to regular tests, so we can know when things break on that version specifically way before we build a new snapshot? |
Done. |
nazar-pc
previously approved these changes
Dec 21, 2021
|
Looks like MSVC pinning to older version is needed to make it compile on Windows 2022 (probably defaults to newer version) |
|
Just adding it is not enough, MSVC is already working. The point of adding |
nazar-pc
force-pushed
the
Windows-2022-Upgrade
branch
from
6c7e42e to
f92f112
Compare
nazar-pc
approved these changes
Dec 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding windows-2022 server to build for matrix os, should add Windows 11 compatibility on next release.
Closes #215