Simplify bootstrapping process #1699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nazar-pc
force-pushed
the
change_bootstrapping-simplification
branch
from
e8bf334 to
76e464a
Compare
|
This seems simpler and it appears to work as expected: #1702 |
Most of the time yes, but it is not doing precisely what we need and nothing else. This PR does. |
shamil-gadelshin
requested changes
Jul 26, 2023
| let mut bootstrap_command_state = bootstrap_command_state.lock().await; | ||
| let bootstrap_command_receiver = match &mut *bootstrap_command_state { | ||
| BootstrapCommandState::NotStarted => { | ||
| error!("Bootstrap started."); |
There was a problem hiding this comment.
Suggested change
| error!("Bootstrap started."); | |
| debug!("Bootstrap started."); |
| @@ -246,14 +253,38 @@ where | |||
|
|
|||
| /// Bootstraps Kademlia network | |||
| async fn bootstrap(&mut self) { | |||
| self.was_bootstrapped = true; | |||
| let bootstrap_command_state = Arc::clone(&self.bootstrap_command_state); | |||
There was a problem hiding this comment.
Suggested change
| let bootstrap_command_state = Arc::clone(&self.bootstrap_command_state); | |
| let bootstrap_command_state = self.bootstrap_command_state.clone(); |
1 task
ParthDesai
added a commit
to autonomys/subspace-pulsar-sdk
that referenced
this pull request
Aug 4, 2023
ParthDesai
added a commit
to autonomys/subspace-pulsar-sdk
that referenced
this pull request
Aug 5, 2023
ParthDesai
added a commit
to autonomys/subspace-pulsar-sdk
that referenced
this pull request
Aug 15, 2023
ParthDesai
added a commit
to autonomys/subspace-pulsar-sdk
that referenced
this pull request
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code contributor checklist: