Upgrade Substrate (with core-evm-relay
removed)
#1549
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the most minimal update possible just to make it compile without warnings and produce blocks. There will be subsequent PR with more dependencies updated.
core-evm-relay
is not useful anymore and was very hard to upgrade, so it had to go.There are some breaking changes and I highly recommend to at least go through the list of mentioned PRs. In our fork I did rebase (which did not require major refactoring).
If you can test some of the domains and other stuff with this PR that'd be awesome.
Some interesting/notable/relevant upstream Substrate PRs:
sc-network
forProtocolController
/NotificationService
paritytech/substrate#14080type Migrations
toConfig
paritytech/substrate#14309Snowbridge (eventually
core-eth-relay
was removed):Frontier:
pallet-timestamp
frompallet-evm
andpallet-ethereum
polkadot-evm/frontier#1050Breaking changes:
std::time::Duration
(it is caused by ImplementTypeInfo
forDuration
paritytech/scale-info#183 for which I sent a PR, butDuration
is serialized into(u64, u32)
, which is excessive for us and requires extra conversions down the line anyway)serde
serialization insp-domains
was not usingcamelCase
naming for fields (idiomatic in JSON), I changed it to do that nowcore-eth-relay
was removed due to seeming uselessness and difficulty of upgradetest_cross_domains_message_should_work
test was commented-out due to dependency oncore-eth-relay
Code contributor checklist: