Improve archiver performance (part 2) #1346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nazar-pc
force-pushed
the
improve-archiver-performance-part-2
branch
from
4665a0e
to
c2bbc11
Compare
shamil-gadelshin
approved these changes
Apr 3, 2023
i1i1
approved these changes
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was still too slow to run tests, taking minutes for a single run with increased record size.
This decreases time to run archiver tests on my machine from 31.01s to 15.35s with current parameters, or ~2x time reduction thanks to use of parallelism. It will also be reflected in production use.
Incremental record commitments now trades memory usage to achieve parallelization. Previously it was designed to use as little memory as possible.
Code contributor checklist: