Add root block storage to node. #1120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shamil-gadelshin
added
farmer
nazar-pc
reviewed
Jan 31, 2023
There was a problem hiding this comment.
This generally makes sense to me, but it doesn't remove (as discussed) additional record roots storage in sc-consensus-subspace. If implemented there, there would probably be less code in general, no need to have another task and logic could be de-duplicated. Also now that we have records_roots we should probably remove records_roots and use records_roots instead.
TL;DR: This just adds more code on top without trying to de-duplicate logic and clean things up in the process. I'll have to do more refactoring on top if not done initially.
Co-authored-by: Nazar Mokrynskyi <[email protected]>
shamil-gadelshin
requested review from
i1i1,
rg3l3dr and
liuchengxu
as code owners
nazar-pc
approved these changes
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds root blocks storage and API as part of the piece verification process. Fixes #1118
Code contributor checklist: