-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DSN optimizations (part 4) #1101
Conversation
…ing stored in a plot
…nder` for cleaner and reactive API everywhere
…more flexibility for caller that we'll take advantage of later
@i1i1 please look carefully at the description of this PR, it describes some key changes that were partially true on the SDK side, but not entirely (with node and farmer you'll have two caches: recently archived segments on node and regular piece cache on the farmer for instance). It'll need to be corrected and I'll do further refactoring to expose more of the primitives that you can assemble the way you need it in SDK (right now there will be a bit more copy-paste required than I'd like to see). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Simplify cache size handling and make it explicit
# Conflicts: # crates/subspace-farmer/src/bin/subspace-farmer/commands/farm/dsn.rs
This is where refactoring was going up until this point.
During plotting:
During announcements:
There is still one more optimization I came up with, but left it for later in #1100
Fixes #1076
Code contributor checklist: