Gossip regular domain transaction #1096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The service actually wasn't started before due to some missing pieces.
vedhavyas
approved these changes
Jan 23, 2023
nazar-pc
approved these changes
Jan 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, you have to submit the domain extrinsic to a domain authority node as the domain extrinsics are not gossiped between the domain nodes. This PR aims to fix it using the gossip extension added in #989, the first commit fixes an issue of the gossip extension not started in fact, and the second one spawns a task which listens the transaction import notification and tries to gossip the regular transaction to the other domain nodes.
Code contributor checklist: