Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Discord Bot Automatic Deployment #19

Merged
merged 3 commits into from
Nov 7, 2023

Conversation

marc-aurele-besner
Copy link
Collaborator

Improve Discord Bot Automatic Deployment

  • add all needed env in workflows

By passing all the env at deployment time in the workflow, we should not have to manually add the env in AWS anymore

Copy link

netlify bot commented Nov 3, 2023

Deploy Preview for subspacefaucet ready!

Name Link
🔨 Latest commit 0acb37e
🔍 Latest deploy log https://app.netlify.com/sites/subspacefaucet/deploys/654993e796c7e70008cdae6e
😎 Deploy Preview https://deploy-preview-19--subspacefaucet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@EmilFattakhov EmilFattakhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few non-blocking comments, might or might not need adjustment depending on your response.

.github/workflows/discord-bot-deployment.yml Outdated Show resolved Hide resolved
.github/workflows/discord-bot-deployment.yml Outdated Show resolved Hide resolved
Copy link
Collaborator

@EmilFattakhov EmilFattakhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you for addressing the comments!

@marc-aurele-besner marc-aurele-besner merged commit 097bba9 into main Nov 7, 2023
7 checks passed
@marc-aurele-besner marc-aurele-besner deleted the ft/improveDiscordBotAutomaticDeployment branch November 25, 2023 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants