Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mobile menu footer #973

Merged
merged 4 commits into from
Nov 19, 2024
Merged

Fix mobile menu footer #973

merged 4 commits into from
Nov 19, 2024

Conversation

marc-aurele-besner
Copy link
Collaborator

@marc-aurele-besner marc-aurele-besner commented Nov 19, 2024

User description

Fix mobile menu footer


PR Type

enhancement, bug fix


Description

  • Updated the footer text across multiple components to reflect the new organization name, "Autonomys Network, Inc."
  • Modified the ErrorFallback component to use a constant for the external service status page URL.
  • Updated metadata keywords to remove references to the old organization name.
  • Added a new status page URL to the EXTERNAL_ROUTES constant.

Changes walkthrough 📝

Relevant files
Enhancement
index.tsx
Update footer organization name in WalletSideKick component

explorer/src/components/WalletSideKick/index.tsx

  • Updated footer text to reflect new organization name.
+1/-1     
index.tsx
Use constants for external routes in ErrorFallback             

explorer/src/components/common/ErrorFallback/index.tsx

  • Imported EXTERNAL_ROUTES for external links.
  • Updated service status page link to use EXTERNAL_ROUTES.
  • +2/-1     
    Footer.tsx
    Update footer organization name in layout Footer component

    explorer/src/components/layout/Footer.tsx

    • Updated footer text to reflect new organization name.
    +1/-1     
    MobileHeader.tsx
    Update footer organization name in MobileHeader component

    explorer/src/components/layout/MobileHeader.tsx

    • Updated footer text to reflect new organization name.
    +1/-1     
    metadata.ts
    Update metadata keywords for new organization                       

    explorer/src/constants/metadata.ts

    • Updated keywords to remove references to old organization name.
    +1/-1     
    routes.ts
    Add status page URL to external routes                                     

    explorer/src/constants/routes.ts

    • Added status page URL to EXTERNAL_ROUTES.
    +1/-0     

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    @marc-aurele-besner marc-aurele-besner linked an issue Nov 19, 2024 that may be closed by this pull request
    Copy link

    netlify bot commented Nov 19, 2024

    Deploy Preview for dev-astral ready!

    Name Link
    🔨 Latest commit b256b04
    🔍 Latest deploy log https://app.netlify.com/sites/dev-astral/deploys/673ce884fd11fe0008e9b75f
    😎 Deploy Preview https://deploy-preview-973--dev-astral.netlify.app
    📱 Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.

    To edit notification comments on pull requests, go to your Netlify site configuration.

    Copy link

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Code Consistency
    The footer text update should be consistent across all components. Ensure that all instances of the old organization name are updated to the new one.

    Hardcoded URL Removal
    The hardcoded URL has been replaced with a constant, which is a good practice for maintainability and configurability.

    Copy link

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Score
    Possible issue
    Verify the availability and correctness of the service status URL

    Ensure that the EXTERNAL_ROUTES.status is correctly defined and accessible. This is
    critical as it affects the user's ability to access service status information,
    which is crucial during downtimes or issues.

    explorer/src/components/common/ErrorFallback/index.tsx [22]

    -href={EXTERNAL_ROUTES.status}
    +href={EXTERNAL_ROUTES.status} // Ensure this URL is correct and the server is responsive
    Suggestion importance[1-10]: 1

    Why: The suggestion to verify the URL's availability and correctness is valid but does not directly improve the code's functionality or quality. It's more of a reminder or check rather than a code improvement.

    1

    @marc-aurele-besner marc-aurele-besner marked this pull request as ready for review November 19, 2024 18:34
    @marc-aurele-besner marc-aurele-besner merged commit 5265b15 into main Nov 19, 2024
    12 checks passed
    @marc-aurele-besner marc-aurele-besner deleted the 972-fix-mobile-menu-footer branch November 19, 2024 19:40
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    Fix mobile menu footer
    3 participants