Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add development guidelines #63

Merged
merged 5 commits into from
Oct 22, 2024
Merged

Add development guidelines #63

merged 5 commits into from
Oct 22, 2024

Conversation

aiman
Copy link
Contributor

@aiman aiman commented Oct 9, 2024

Add development guidelines document describing the release checklist for maintainers.

@aiman aiman marked this pull request as draft October 9, 2024 11:30
@aiman aiman force-pushed the development-guidelines branch 5 times, most recently from 18ccfd9 to 8d360ec Compare October 9, 2024 11:56
@aiman aiman requested a review from szemate October 9, 2024 11:57
@aiman aiman marked this pull request as ready for review October 9, 2024 11:57
Copy link
Contributor

@szemate szemate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think RELEASE.md and "Release Guidelines" would be more appropriate as this document is more about creating a new release than contributing to development.

@szemate
Copy link
Contributor

szemate commented Oct 9, 2024

...or the "Development" section from README.md could be moved into this document.

@aiman aiman force-pushed the development-guidelines branch 11 times, most recently from 0bf68b1 to 283537c Compare October 9, 2024 13:16
@aiman
Copy link
Contributor Author

aiman commented Oct 9, 2024

I've gone with latter idea of moving content out of the README, and also expanding it. @szemate could you review again and let me know your thoughts.

@aiman aiman marked this pull request as draft October 10, 2024 10:54
@aiman aiman marked this pull request as ready for review October 22, 2024 11:23
@aiman
Copy link
Contributor Author

aiman commented Oct 22, 2024

@szemate I've rebased on master and updated the content significantly, please take another look

Copy link
Contributor

@szemate szemate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@aiman aiman merged commit 617847f into master Oct 22, 2024
10 checks passed
@aiman aiman deleted the development-guidelines branch October 22, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants