-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Additional metrics during training #316
[FIX] Additional metrics during training #316
Conversation
Codecov Report
@@ Coverage Diff @@
## development #316 +/- ##
===============================================
- Coverage 82.01% 81.78% -0.24%
===============================================
Files 151 152 +1
Lines 8652 8669 +17
Branches 1322 1325 +3
===============================================
- Hits 7096 7090 -6
- Misses 1088 1113 +25
+ Partials 468 466 -2
Continue to review full report at Codecov.
|
ed80520
to
7680410
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the change.
I added two minor suggestions.
self.fit_dictionary['runtime'] = self.budget | ||
self.fit_dictionary.pop('epochs', None) | ||
else: | ||
raise ValueError(f"Unsupported budget type {self.budget_type} provided") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
raise ValueError(f"Unsupported budget type {self.budget_type} provided") | |
raise ValueError(f"budget type must be `epochs` or `runtime`, but got {self.budget_type}") |
Co-authored-by: nabenabe0928 <[email protected]>
This PR fixes #101