Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC] Adds documentation to the abstract evaluator #160
[DOC] Adds documentation to the abstract evaluator #160
Changes from 1 commit
0dc9d3a
a0c87fb
f66fceb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you create
PipelineConfig
object?For example, I created a
DaskFutureTaskType
object as follows:In this case, we should use
dataclasses
(which is unstable in python3.6) orNamedTuple
.Since we do not instantiate the object,
NamedTuple
is ok, but if it should not be immutable, technically we should useAttrDict
, which I introduced before.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to honor the title of the PR and only address documentation-related changes. This looks like a refactor.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you give a reference such as URL for pipeline steps or creating
Pipeline
object?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are multiple pipeline types, not a single one. For example, the traditional pipeline is different than a dummy classifier. So there is not a single pipeline we can point to?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
scikit is using
y_pred
instead ofy_hat
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to honor the title of the PR and only address documentation-related changes. This looks like a refactor.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably we can change the line before
This will
and start the next line withThis will
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the trouble. Could you elaborate? Also, could you use a suggestion in github?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably, we should discuss the usage of test and validation sets given by user.
Because we currently do not use test dataset at all although it is provided.
Also, since user splits dataset and the dataset that is created before user splits will be stored on RAM.
It also increases the memory usage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do use the test! We score the test performance to closely track the overfit. If no test data is provided, then no consumption here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uum, can we change the name like
Y_cv_pred
?It is the performance on the cross validation (or holdout validation) rather than optimized performance, right? (Another reason why I thought it is strange is that we would not know in terms of what we optimize the performance.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to honor the title of the PR and only address documentation-related changes. This looks like a refactor.