-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add build_info data #52
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
btw i did this in python today if you want to compare notes |
ah nice thanks! I updated the |
stephlow
approved these changes
May 11, 2023
oscarvz
approved these changes
May 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from some code style nits, lgtm!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #45
This update adds
build_info
data to the metrics exported. Whenever the firstautometrics
wrapper is called it will create an object that will persistingthrough the runtime and report version, commit, and branch data (depending on
what is supplied). The data can be supplied through env variables:
version: picked up automatically if the package is run through
npm
,yarn
, orpnpm
, - can be manually supplied throughPACKAGE_VERSION
orAUTOMETRICS_VERSION
otherwise.commit: must be supplied through
COMMIT_SHA
orAUTOMETRICS_COMMIT
env variablebranch: must be supplied through
BRANCH_NAME
orAUTOMETRICS_BRANCH
env variableThe update also fixes a previous functionality that would throw an error if a
function without a name was supplied. It will now just log a warning and returns the
function early without attempting to instrument.