Add build_info metric & use it in generated queries #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mellowagain
approved these changes
Apr 19, 2023
|
@mellowagain if you don't provide |
gagbo
added a commit
to autometrics-dev/autometrics-go
that referenced
this pull request
Apr 21, 2023
This allows use cases where we can see and query the changes in metrics after a version change in the code base. Ref: autometrics-dev/autometrics-rs#69 Ref: https://github.com/orgs/autometrics-dev/discussions/10
This was referenced May 2, 2023
Closed
gagbo
added a commit
to autometrics-dev/autometrics-go
that referenced
this pull request
May 9, 2023
* Add build information to the metrics/queries This allows use cases where we can see and query the changes in metrics after a version change in the code base. Ref: autometrics-dev/autometrics-rs#69 Ref: https://github.com/orgs/autometrics-dev/discussions/10 * Add --help and --version flags to the binary Closes: #36 * !Breaking: Use go-arg to parse generator arguments Breaking change: the long flags in autometrics now take the long form arguments starting with -- Also removes the unused `am-alertsgen` binary. Even though for the time being we are using sloth to generate the alerts, at some point we might want to change, and adding extra code/friction to do the change seems unwarranted for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The queries get uglier, but I think it's a pretty great feature 😁
Implements https://github.com/orgs/autometrics-dev/discussions/10