Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automata DCAP Attestation Audit Submission For Release (November 2024) #6

Merged
merged 36 commits into from
Nov 20, 2024
Merged

Automata DCAP Attestation Audit Submission For Release (November 2024) #6

merged 36 commits into from
Nov 20, 2024

Conversation

preston4896
Copy link
Collaborator

Overview

New changes included in this PR that we are planning to roll out for the next release of both Automata On-Chain PCCS and Automata DCAP Attestation.

Major change(s) included in this PR:

  • P256 Verifier Configuration upon deployment.
    0dc5733
    4843211
  • AutomataDcapAttestationFee.sol
    66a90fc
    fa076d4
    52431ee
  • SP1 Integration
    0dc5733
    17faa2d (Note: Ignore IZKVerifier.sol)
    148f887
  • PCCS Router updates to ensure all contracts must read collaterals from the Router and added access-control measures to support AutomataDcapAttestatonFee.sol
    0440a1c
    0135e42

When auditing is in progress, expect the following:

  • Upon finalization of this PR (Converted to Ready To Review status), there shall be no more major breaking changes introduced to this PR. (e.g. external API changes)
  • Code optimizations may require minor changes on internal methods.
  • Revision(s) that may be necessary based on findings from auditing. (May be exempted from the "no breaking changes" rule)

@preston4896
p256 configuration to use RIP7212 precompile if available
1839483
@preston4896
forge install: sp1-contracts
0dc5733 
v3.0.0
@preston4896
zk verifier contract interface compatible with risczero, succinct, ot…
17faa2d 
…her zk-coprocessors we may support in the future
@preston4896
Merge branch 'DEV-3441' into DEV-3373/audit
23d9fe1
@preston4896
added DCAP Attestation with Fee contract and refactored code
66a90fc
@preston4896
minor fix: pausable
fa076d4
@preston4896
forge update: on-chain pccs
1fb3e5f
@preston4896
pccs router update and all contracts must read collaterals via the pc…
0440a1c 
…cs router
@preston4896
added the ability to simulate gas cost directly from contract
52431ee
@preston4896
code formatting
ff8557d
@preston4896
pccs router caller check and minor fix for deployment script
0135e42
@preston4896
upgrade tests to run verification on sp1 v3 proofs
148f887
@preston4896
forge-update: on-chain pccs to sync with audit submission
9e92eae
@preston4896
v4 tee check
a4de996
@preston4896
NatSpec comment updates
dcc80f9
@preston4896
use revert when the script cannot find a p256 verifier
4843211
@preston4896
fixed test code
a29cdba
@preston4896
updated README.md
b206352
@preston4896
store slither report as sarif
38403da
@preston4896
commenting out sp1 groth16 test code because its failing ci due to co…
890aaa3 
…mpiler config
@preston4896 preston4896 changed the title Automata DCAP Attestation Audit Submission For V1.0.0 Release (November 2024) Automata DCAP Attestation Audit Submission For Release (November 2024) Nov 8, 2024
Liao1
Liao1 reviewed Nov 11, 2024
View reviewed changes
contracts/AttestationEntrypointBase.sol Show resolved Hide resolved
contracts/AutomataDcapAttestation.sol Outdated Show resolved Hide resolved
contracts/bases/FeeManagerBase.sol Outdated Show resolved Hide resolved
contracts/AutomataDcapAttestationFee.sol Outdated Show resolved Hide resolved
contracts/AutomataDcapAttestationFee.sol Outdated Show resolved Hide resolved
contracts/bases/FeeManagerBase.sol Outdated Show resolved Hide resolved
Liao1
Liao1 reviewed Nov 12, 2024
View reviewed changes
contracts/AttestationEntrypointBase.sol Show resolved Hide resolved
contracts/AttestationEntrypointBase.sol Outdated Show resolved Hide resolved
contracts/bases/FeeManagerBase.sol Outdated Show resolved Hide resolved
contracts/AutomataDcapAttestationFee.sol Outdated Show resolved Hide resolved
contracts/bases/FeeManagerBase.sol Outdated Show resolved Hide resolved
@preston4896 preston4896 marked this pull request as ready for review November 19, 2024 08:01
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 19, 2024
View reviewed changes
contracts/AttestationEntrypointBase.sol Dismissed Show dismissed Hide dismissed
contracts/AttestationEntrypointBase.sol Dismissed
@@ -0,0 +1,171 @@
//SPDX-License-Identifier: MIT
pragma solidity ^0.8.0;

Check warning

Code scanning / Slither

Incorrect versions of Solidity Warning

Version constraint ^0.8.0 contains known severe issues (https://solidity.readthedocs.io/en/latest/bugs.html)
- FullInlinerNonExpressionSplitArgumentEvaluationOrder
- MissingSideEffectsOnSelectorAccess
- AbiReencodingHeadOverflowWithStaticArrayCleanup
- DirtyBytesArrayToStorage
- DataLocationChangeInInternalOverride
- NestedCalldataArrayAbiReencodingSizeValidation
- SignedImmutables
- ABIDecodeTwoDimensionalArrayMemory
- KeccakCaching.
It is used by:
- ^0.8.0
- ^0.8.0
- ^0.8.0
- ^0.8.0
- ^0.8.0
- ^0.8.0
- ^0.8.0
- ^0.8.0
- ^0.8.0
- ^0.8.0
- ^0.8.0
- ^0.8.0
- ^0.8.0
- ^0.8.0
- ^0.8.0
- ^0.8.0
- ^0.8.0
- ^0.8.0
- ^0.8.0
- ^0.8.0
- ^0.8.0
- ^0.8.0
- [^0.8.0](https://github.com/automata-network/automata-dcap-attestation/blob/c78982bf21a8fa664e59c9
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/ethereum/solidity/blob/develop/docs/bugs_by_version.json

contracts/AutomataDcapAttestationFee.sol Dismissed Show dismissed Hide dismissed
contracts/bases/FeeManagerBase.sol Dismissed Show dismissed Hide dismissed
contracts/bases/FeeManagerBase.sol Dismissed Show dismissed Hide dismissed
contracts/bases/QuoteVerifierBase.sol Dismissed Show dismissed Hide dismissed
contracts/bases/QuoteVerifierBase.sol Dismissed Show dismissed Hide dismissed
contracts/utils/P256Verifier.sol Dismissed Show dismissed Hide dismissed
contracts/verifiers/V4QuoteVerifier.sol Dismissed Show dismissed Hide dismissed
@preston4896 preston4896 merged commit 1041bde into main Nov 20, 2024
3 checks passed
@preston4896 preston4896 deleted the DEV-3373/audit branch November 20, 2024 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Liao1 Liao1 Liao1 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@preston4896 @Liao1