Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MaterialX install is not relocatable #1347

Closed
JGamache-autodesk opened this issue Dec 21, 2021 · 1 comment
Closed

MaterialX install is not relocatable #1347

JGamache-autodesk opened this issue Dec 21, 2021 · 1 comment

Comments

@JGamache-autodesk
Copy link
Collaborator

This means a MaterialX install done to a staging area using -DCMAKE_INSTALL_PREFIX=/my/stage can not be packaged and installed somewhere else.

Problem is in /my/stage/lib/cmake/MaterialX/MaterialXTargets.cmake which will contain the line:

set(_IMPORT_PREFIX "/my/stage")

There is a mechanism in CMake to keep the MaterialX generated CMake file relocatable and it hinges on keeping all install paths relative.

I would recommend centralizing the library creation into a CMake function that would insure all path are local, this is what is done in USD and it generates a relocatable CMake file.

@JGamache-autodesk
Copy link
Collaborator Author

Fixed via PR #1350 in this repo.
Merged back to ILM repo via AcademySoftwareFoundation#805

ashwinbhat pushed a commit that referenced this issue May 15, 2023
The full MaterialX v1.39 WIP specification, converted to Markdown format for easier contributing, commenting and external linking from the community. Since v1.39 is still a work in progress, the documents are placed in an "inprog_v1.39" subfolder until v1.39 is agreed to be ready for release.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant